On 9/30/2016 4:13 PM, Hrishikesh Gadre wrote: > As I mentioned in SOLR-9542 > <https://issues.apache.org/jira/browse/SOLR-9542>, we can remove guava > dependency in solrj by getting rid of the annotation added for a test > method. Also jackson dependency can be replaced with noggit.
The guava dependency definitely looks like something that's completely unnecessary. The annotation that was added (com.google.common.annotations.VisibleForTesting) seems like something that can be handled in Javadoc. If the existing javadoc is not clear enough, we should just fix that, allowing us to remove the annotation and the dependency. Thanks, Shawn --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
