[ 
https://issues.apache.org/jira/browse/SOLR-4164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15542879#comment-15542879
 ] 

Hoss Man commented on SOLR-4164:
--------------------------------

At a minimum, if distributed grouping doesn't work with {{group.limit=-1}} then 
we should give a clean error saying so rather than an obtuse error.

IIUC though, what Dat has found is that even in single node solr, 
{{group.limit=-1}} doesn't give you "unlimited" groupping results -- it 
silently re-writes the effective groupedDocsToCollect value to '1' ... I'm not 
sure why it does that instead of just giving an error, but if we can make 
distributed grouping behave the exact same way (and i'm not sure why we 
couldn't have the same {{Math.max(groupedDocsToCollect, 1);}} in the 
distributed code path) then we should.

> Result Grouping fails if no hits
> --------------------------------
>
>                 Key: SOLR-4164
>                 URL: https://issues.apache.org/jira/browse/SOLR-4164
>             Project: Solr
>          Issue Type: Bug
>          Components: SearchComponents - other, SolrCloud
>    Affects Versions: 4.0
>            Reporter: Lance Norskog
>            Assignee: Cao Manh Dat
>
> In SolrCloud, found a result grouping bug in the 4.0 release.
> A distributed result grouping request under SolrCloud got this result:
> {noformat}
> Dec 10, 2012 10:32:07 PM org.apache.solr.common.SolrException log
> SEVERE: null:java.lang.IllegalArgumentException: numHits must be > 0; please 
> use TotalHitCountCollector if you just need the total hit count
>         at 
> org.apache.lucene.search.TopFieldCollector.create(TopFieldCollector.java:1120)
>         at 
> org.apache.lucene.search.TopFieldCollector.create(TopFieldCollector.java:1069)
>         at 
> org.apache.lucene.search.grouping.AbstractSecondPassGroupingCollector.<init>(AbstractSecondPassGroupingCollector.java:75)
>         at 
> org.apache.lucene.search.grouping.term.TermSecondPassGroupingCollector.<init>(TermSecondPassGroupingCollector.java:49)
>         at 
> org.apache.solr.search.grouping.distributed.command.TopGroupsFieldCommand.create(TopGroupsFieldCommand.java:128)
>         at 
> org.apache.solr.search.grouping.CommandHandler.execute(CommandHandler.java:132)
>         at 
> org.apache.solr.handler.component.QueryComponent.process(QueryComponent.java:339)
>         at 
> org.apache.solr.handler.component.SearchHandler.handleRequestBody(SearchHandler.java:206)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to