[ 
https://issues.apache.org/jira/browse/SOLR-9592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15546847#comment-15546847
 ] 

Yonik Seeley commented on SOLR-9592:
------------------------------------

bq. Are you disagree with renaming(-1) or weakly agree with(+0)? 

I supposed weakly agree :-)

bq. Because, at first glance, getLeafReader 

Yeah, I really don't care for that name.

bq. If my understanding is clear, we should use MultiDocValues in cases where 
you essencially need global view and decorateDocValues usage is not the case 
right?

Right.  Sometimes you need both a global view and a segment view to do it 
right.  See something like FacetFieldProcessorByArrayDV, where we use both top 
level and segment level.

decorateDocValues would seem to only need segment level access.

> decorateDocValues cause serious performance issue because of using 
> slowCompositeReaderWrapper
> ---------------------------------------------------------------------------------------------
>
>                 Key: SOLR-9592
>                 URL: https://issues.apache.org/jira/browse/SOLR-9592
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: Response Writers, search
>    Affects Versions: 6.0, 6.1, 6.2
>            Reporter: Takahiro Ishikawa
>              Labels: performance
>             Fix For: 6.3, master (7.0)
>
>         Attachments: SOLR-9592.patch, SOLR-9592.patch, SOLR-9592_6x.patch
>
>
> I have serious performance issue using AtomicUpdate (and RealtimeGet) with 
> non stored docValues.
> Because decorateDocValues try to merge each leafLeader on the fly via 
> slowCompositeReaderWrapper and it’s extremely slow (> 10sec).
> Simply access docValues via nonCompositeReader could resolve this 
> issue.(patch) 
> AtomicUpdate performance(or RealtimeGet performance)
> * Environment
> ** solr version : 6.0.0
> ** schema ~ 100 fields(90% docValues, some of those are multi valued)
> ** index : 5,000,000
> * Performance
> ** original :  > 10sec per query
> ** patched : at least 100msec per query
> This patch will also enhance search performance, because DocStreamer also 
> fetch docValues via decorateDocValues.
> Though it depends on each environment, I could take 20% search performance 
> gain.
> (This patch originally written for solr 6.0.0, and now rewritten for master)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to