[ 
https://issues.apache.org/jira/browse/SOLR-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13026799#comment-13026799
 ] 

Mark Miller commented on SOLR-2191:
-----------------------------------

Also keep in mind that Review-Then-Commit at Apache means you need consensus 
and 3 votes before committing I believe:

See

http://www.apache.org/foundation/glossary.html


Consensus Approval
'Consensus approval' refers to a vote (sense 1) which has completed with at 
least three binding +1 votes and no vetos. Compare .

Review-Then-Commit
(Often referenced as 'RTC' or 'R-T-C'.) Commit policy which requires that all 
changes receive consensus approval in order to be committed. Compare , and see 
the description of the voting process.

> Change SolrException cstrs that take Throwable to default to 
> alreadyLogged=false
> --------------------------------------------------------------------------------
>
>                 Key: SOLR-2191
>                 URL: https://issues.apache.org/jira/browse/SOLR-2191
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Mark Miller
>             Fix For: Next
>
>         Attachments: SOLR-2191.patch
>
>
> Because of misuse, many exceptions are now not logged at all - can be painful 
> when doing dev. I think we should flip this setting and work at removing any 
> double logging - losing logging is worse (and it almost looks like we lose 
> more logging than we would get in double logging) - and bad 
> solrexception/logging patterns are proliferating.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to