[ https://issues.apache.org/jira/browse/SOLR-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13026830#comment-13026830 ]
David Smiley commented on SOLR-2191: ------------------------------------ Thanks for clarification on Review Then Commit (RTC); I verified through ASF's documentation that indeed three votes is necessary. Wow, it'd take forever to get things done that way; it seems impractical for anything but perhaps security related code (e.g. crypto). I didn't see any info exceptions for "minor" changes (e.g. adding documentation, code formatting). I'm glad we don't do that officially. I'm about to take the conversation further on the dev list RE jira issues falling through the cracks... > Change SolrException cstrs that take Throwable to default to > alreadyLogged=false > -------------------------------------------------------------------------------- > > Key: SOLR-2191 > URL: https://issues.apache.org/jira/browse/SOLR-2191 > Project: Solr > Issue Type: Bug > Reporter: Mark Miller > Fix For: Next > > Attachments: SOLR-2191.patch > > > Because of misuse, many exceptions are now not logged at all - can be painful > when doing dev. I think we should flip this setting and work at removing any > double logging - losing logging is worse (and it almost looks like we lose > more logging than we would get in double logging) - and bad > solrexception/logging patterns are proliferating. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org