[ 
https://issues.apache.org/jira/browse/LUCENE-7476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15555201#comment-15555201
 ] 

Michael McCandless commented on LUCENE-7476:
--------------------------------------------

Thanks [~andyhind].

Do you have a {{Reproduce with: ...}} line showing the test failure?  What's 
spooky about this is that one should never call {{incrementToken}} after it has 
already returned false, and token filters should not be required / expected to 
guard against such abuse (this patch), so I'd like to understand who is abusing 
{{JapaneseNumberFilter}}'s {{incrementToken}} in this test failure.

> Fix transient failure in JapaneseNumberFilter run from TestFactories
> --------------------------------------------------------------------
>
>                 Key: LUCENE-7476
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7476
>             Project: Lucene - Core
>          Issue Type: Bug
>          Components: core/other
>    Affects Versions: 6.2.1
>            Reporter: Andy Hind
>            Priority: Trivial
>         Attachments: LUCENE-7476.patch
>
>
> Repeatedly running TestFactories show this test to fail ~10% of the time.
> I believe the fix is trivial and related to loosing the state of the 
> underlying input stream when testing some analyzer life cycle flows. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to