[ https://issues.apache.org/jira/browse/LUCENE-7283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15558656#comment-15558656 ]
Yonik Seeley commented on LUCENE-7283: -------------------------------------- bq. In ancient Lucene versions, sorting was not a "first class citizen" and hacks like field cache were necessary. Yes, a hack that has been with us for more than *12 years* already (FieldCache came about in 2004). Best practice is one thing (Solr uses docvalues by default), but removing the option is different. After a quick google, it doesn't appear like you're removing this ability from elasticsearch (fielddata is the ES equivalent of the Lucene FieldCache): https://www.elastic.co/guide/en/elasticsearch/reference/5.x/modules-fielddata.html https://www.elastic.co/guide/en/elasticsearch/reference/current/fielddata.html > Move SlowCompositeReaderWrapper and uninverting package to solr sources > ----------------------------------------------------------------------- > > Key: LUCENE-7283 > URL: https://issues.apache.org/jira/browse/LUCENE-7283 > Project: Lucene - Core > Issue Type: Improvement > Reporter: Michael McCandless > Assignee: Michael McCandless > Fix For: 6.1, master (7.0) > > Attachments: LUCENE-7283.patch > > > Spinoff from LUCENE-6766, where we fixed index-time sorting to have first > class support in Lucene's ore, and no longer use > {{SlowCompositeReaderWrapper}}. > This is a dangerous, long living class, that tries to pretend a set of N > segments is actually just a single segment. It's a leaky abstraction, has > poor performance, and puts undue pressure on the APIs of new Lucene features > to try to keep up this illusion. > With LUCENE-6766, finally all usage of this class (except for > {{UninvertedReader}} tests, which should maybe also move out?) has been > removed from Lucene, so I think we should move it to Solr. This may also > lead to a solution for LUCENE-7086 since e.g. the class could tap into solr's > schema to "know" how to handle points fields properly. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org