[ 
https://issues.apache.org/jira/browse/SOLR-9103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15562874#comment-15562874
 ] 

Dennis Gove commented on SOLR-9103:
-----------------------------------

testDynamicLoadingCustomStream is not passing because it cannot find 
runtimecode/HelloStream.class. Note that I did add the file 
solr/core/src/test-files/runtimecode/HelloStream.java. But it doesn't appear 
the test can find the .class of that. I know you provided a .class but I'm not 
sure I'm comfortable adding a .class to the source code.

The test does pass if I run it directly in Eclipse, however.

{code}
   [junit4]   2> NOTE: reproduce with: ant test  -Dtestcase=TestCustomStream 
-Dtests.method=testDynamicLoadingCustomStream -Dtests.seed=96673E541CBCF992 
-Dtests.slow=true -Dtests.locale=fr-CH -Dtests.timezone=Europe/Sarajevo 
-Dtests.asserts=true -Dtests.file.encoding=ISO-8859-1
   [junit4] ERROR   28.5s | TestCustomStream.testDynamicLoadingCustomStream <<<
   [junit4]    > Throwable #1: java.lang.RuntimeException: Cannot find resource 
in classpath or in file-system (relative to CWD): runtimecode/HelloStream.class
   [junit4]    >        at 
__randomizedtesting.SeedInfo.seed([96673E541CBCF992:E6D23776E646B225]:0)
   [junit4]    >        at 
org.apache.solr.SolrTestCaseJ4.getFile(SolrTestCaseJ4.java:1798)
   [junit4]    >        at 
org.apache.solr.core.TestDynamicLoading.getFileContent(TestDynamicLoading.java:261)
   [junit4]    >        at 
org.apache.solr.core.TestCustomStream.testDynamicLoadingCustomStream(TestCustomStream.java:73)
   [junit4]    >        at 
org.apache.solr.BaseDistributedSearchTestCase$ShardsRepeatRule$ShardsFixedStatement.callStatement(BaseDistributedSearchTestCase.java:985)
   [junit4]    >        at 
org.apache.solr.BaseDistributedSearchTestCase$ShardsRepeatRule$ShardsStatement.evaluate(BaseDistributedSearchTestCase.java:960)
   [junit4]    >        at java.lang.Thread.run(Thread.java:745)
{code}

> Restore ability for users to add custom Streaming Expressions
> -------------------------------------------------------------
>
>                 Key: SOLR-9103
>                 URL: https://issues.apache.org/jira/browse/SOLR-9103
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Cao Manh Dat
>            Assignee: Joel Bernstein
>         Attachments: HelloStream.class, SOLR-9103.PATCH, SOLR-9103.PATCH
>
>
> StreamHandler is an implicit handler. So to make it extensible, we can 
> introduce the below syntax in solrconfig.xml. 
> {code}
> <expressible name="hello" class="org.apache.solr.search.HelloStream"/>
> {code}
> This will add hello function to streamFactory of StreamHandler.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to