Michael McCandless commented on LUCENE-7493:

bq. Should I add test case as an attachment in this bug?

Yes please!

You can e.g. just add a new test method, e.g. {{testZeroLimit}}, to one of the 
existing test cases under {{lucene/facet/src/test/...}} e.g. 
{{TestDrillDownQuery}}, run it using {{ant test -Dtestcase=TestDrillDownQuery 
-Dtests.method=testZeroLimit}} and it should fail at first.  Then fold in your 
changes above, and run the test case again, and it should pass.

Then use {{git diff HEAD}} to make a patch file that you attach back on this 

> Support of TotalHitCountCollector for FacetCollector.search api if numdocs 
> passed as zero.
> ------------------------------------------------------------------------------------------
>                 Key: LUCENE-7493
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7493
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Mahesh
> Hi, 
> I want to do drill down search using FacetCollection below is the code 
> FacetsCollector facetCollector = new FacetsCollector();
> TopDocs topDocs = FacetsCollector.search(st.searcher, filterQuery, limit, 
> facetCollector);
> I just want facet information so I pass limit as zero but I get error 
> "numHits must be > 0; please use TotalHitCountCollector if you just need the 
> total hit count".
> For FacetCollector there is no way to initialize 'TotalHitCountCollector'. 
> Internally it always create either 'TopFieldCollector' or 
> 'TopScoreDocCollector' which does not allow limit as 0. 
> So if limit should be zero then there should be a way that 
> 'TotalHitCountCollector' should be initialized. 
> Better way would be to provide an api which takes query and collector as 
> inputs just like 'drillSideways.search(filterQuery, totalHitCountCollector)'.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to