[ 
https://issues.apache.org/jira/browse/SOLR-9642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15580757#comment-15580757
 ] 

ASF GitHub Bot commented on SOLR-9642:
--------------------------------------

GitHub user hgadre opened a pull request:

    https://github.com/apache/lucene-solr/pull/97

    [SOLR-9642] Refactor the snapshot cleanup mechanism to rely on Lucene

    The current snapshot cleanup mechanism is based on reference counting
    the index files shared between multiple segments. Since this mechanism
    completely skips the Lucene APIs, it is not portable (e.g. it doesn't
    work on 4.10.x version).
    
    This patch provides an alternate implementation which relies exclusively
    on Lucene IndexWriter (+ IndexDeletionPolicy) for cleanup.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/hgadre/lucene-solr SOLR-9642_fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/lucene-solr/pull/97.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #97
    
----
commit 9f2eee48b9171eddcbb63aa716e8943cafeeddaf
Author: Hrishikesh Gadre <hga...@cloudera.com>
Date:   2016-08-10T23:59:31Z

    [SOLR-9642] Refactor the snapshot cleanup mechanism to rely on Lucene
    
    The current snapshot cleanup mechanism is based on reference counting
    the index files shared between multiple segments. Since this mechanism
    completely skips the Lucene APIs, it is not portable (e.g. it doesn't
    work on 4.10.x version).
    
    This patch provides an alternate implementation which relies exclusively
    on Lucene IndexWriter (+ IndexDeletionPolicy) for cleanup.

----


> Refactor the core level snapshot cleanup mechanism to rely on Lucene
> --------------------------------------------------------------------
>
>                 Key: SOLR-9642
>                 URL: https://issues.apache.org/jira/browse/SOLR-9642
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>    Affects Versions: 6.2
>            Reporter: Hrishikesh Gadre
>
> SOLR-9269 introduced a mechanism to create/delete snapshots for a Solr core 
> (using Lucene IndexDeletionPolicy). The current snapshot cleanup mechanism is 
> based on reference counting the index files shared between multiple segments. 
> Since this mechanism completely skips the Lucene APIs, it is not portable 
> (e.g. it doesn't work on 4.10.3 version).
> I propose an alternative implementation which relies exclusively on Lucene 
> IndexWriter (+ IndexDeletionPolicy) for cleanup.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to