[ 
https://issues.apache.org/jira/browse/SOLR-9570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15581677#comment-15581677
 ] 

Jan Høydahl commented on SOLR-9570:
-----------------------------------

This patch also fixes an old bug in the {{bin\solr.cmd}} script, where backing 
up of the {{solr.log}} file is locale-dependent, see
{code}
REM backup log files (use current timestamp for backup name)
For /f "tokens=2-4 delims=/ " %%a in ('date /t') do (set mydate=%%c-%%a-%%b)
For /f "tokens=1-2 delims=/:" %%a in ("%TIME%") do (set mytime=%%a%%b)
{code}

This code assumed a date format of {{MM/DD/YY}} while in Norwegian locale date 
/t prints as {{17.10.2016}}. This code will be gone after this patch :)

> Logs backed up on restart are kept forever
> ------------------------------------------
>
>                 Key: SOLR-9570
>                 URL: https://issues.apache.org/jira/browse/SOLR-9570
>             Project: Solr
>          Issue Type: Bug
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: scripts and tools
>            Reporter: Jan Høydahl
>            Assignee: Jan Høydahl
>              Labels: logging
>             Fix For: 6.3, master (7.0)
>
>         Attachments: SOLR-8370.patch
>
>
> When (re)starting Solr, the start script will backup any existing 
> {{solr.log}} or {{solr_gc.log}} to a file {{solr_log_<date>}} and 
> {{solr_gc_log_<date>}} respectively. That may be all good, but these old 
> copies are never cleaned up, as they are not under the control of log4j.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to