[ 
https://issues.apache.org/jira/browse/SOLR-8332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15586485#comment-15586485
 ] 

Noble Paul commented on SOLR-8332:
----------------------------------


{code:java}
interface ReplicaListTransformer {

  public void transform(List<Replica> replicas);

  public void transformUrls(List<String> shardUrls);

}

{code}

As a I look at the functionality what it should do is to choose a few replicas 
from the available list of replicas. Sometimes, it would like to make a choice 
based on some input from users. It *should not* deal with actual urls. it's the 
responsibility of Solr to map the urls to actual replicas

So, Lets have a much simpler interface

{code:java}
interface ReplicaFilter {
    public List<Replica>  filter(List<Replica> allReplicas, SolrQueryRequest 
req);
}
{code}


> factor HttpShardHandler[Factory]'s url shuffling out into a 
> ReplicaListTransformer class
> ----------------------------------------------------------------------------------------
>
>                 Key: SOLR-8332
>                 URL: https://issues.apache.org/jira/browse/SOLR-8332
>             Project: Solr
>          Issue Type: Wish
>            Reporter: Christine Poerschke
>            Assignee: Christine Poerschke
>            Priority: Minor
>         Attachments: SOLR-8332.patch, SOLR-8332.patch, SOLR-8332.patch
>
>
> Proposed patch against trunk to follow. No change in behaviour intended. This 
> would be as a step towards SOLR-6730.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to