Jan Høydahl commented on SOLR-8370:

bq. They should be the same as far as I can tell.
I disagree. It is an important distinction whether 
{{SchemaSimilarityFactory(PerFieldSimilarityWrapper)}}, with a default of 
{{DFRSimilarityFactor}}, compared to if you explicitly set 
{{DFRSimilarityWrapper}} as the only global similarity without support for 
per-field. So the output is exactly as I wish :) That was why I think that 
"Default" was a reasonable lead text for what {{PerFieldSimilarityWrapper}} 
will use as default similarity for fields that don't have an explicit override.

One option I was thinking about is to make SchemaSimilarityFactory's 
PerFieldSimilarityFactory a named class instead of an anonymous inner class:
class SchemaFieldSimilarity extends PerFieldSimilarityWrapper { ... }
Then the print from the global sim would instead be printing the name of the 
Similarity, not the factory:
      "details":"SchemaFieldSimilarity. Default: DFR I(F)B3(900.0)"},
Naming of this class could be discussed. SolrPerFieldSimilarity, 
SchemaSimilarity, SchemaFieldSimilarity, PerSchemaFieldSimilarityWrapper....

> Display Similarity Factory in use in Schema-Browser
> ---------------------------------------------------
>                 Key: SOLR-8370
>                 URL: https://issues.apache.org/jira/browse/SOLR-8370
>             Project: Solr
>          Issue Type: Improvement
>          Components: UI
>            Reporter: Jan Høydahl
>            Assignee: Jan Høydahl
>            Priority: Trivial
>              Labels: newdev
>             Fix For: 6.3, master (7.0)
>         Attachments: SOLR-8370.patch, SOLR-8370.patch, SOLR-8370.patch, 
> SOLR-8370.patch, SOLR-8370.patch, SOLR-8370.patch, SOLR-8370.patch, 
> screenshot-1.png, screenshot-2.png, screenshot-3.png, screenshot-4.png, 
> screenshot-5.png
> Perhaps the Admin UI Schema browser should also display which 
> {{<similarity>}} that is in use in schema, like it does per-field.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to