[ 
https://issues.apache.org/jira/browse/LUCENE-7512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15594934#comment-15594934
 ] 

Alan Woodward commented on LUCENE-7512:
---------------------------------------

+1, this looks great.

Some of the suppression is fine, things like the linter misinterpreting casts 
as object creation, but we can probably clean up a couple of other places here. 
 For example, does DocSet really need to implement Closeable?  It's only every 
implemented in DocSetBase, and it's a no-op there...

> supress ecj-lint warinings on precommit
> ---------------------------------------
>
>                 Key: LUCENE-7512
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7512
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Mikhail Khludnev
>              Labels: build
>         Attachments: LUCENE-7512-solr-core-src.patch, 
> LUCENE-7512-solr-core-src.patch
>
>
> Turns out the subj noise too much and people miss significant ERRORs.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to