[
https://issues.apache.org/jira/browse/SOLR-8785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15595421#comment-15595421
]
Shawn Heisey edited comment on SOLR-8785 at 10/21/16 3:59 PM:
--------------------------------------------------------------
bq. RequestHandler stats are now persistent, and will no longer reset on reload.
If I understand this correctly, then I don't think we want to do this. Perhaps
I don't understand it correctly?
There needs to be a way to reset the statistics to zero. Reloading the core is
currently the way that I do this. (I'm not running cloud)
I don't want you to think I'm completely against persistence. The idea is VERY
nice, but having it turned on by default could cause issues for users with
existing workflows. I think the way to handle this particular feature is:
* Introduce a new config parameter to enable persistence. Default the
parameter to "false".
* Discuss a new default of "true" in 7.0. If consensus is to change the
default in master (which probably is a good idea), then enable it in 6.x
example configs so it most brand-new setups will use it.
was (Author: elyograg):
bq. RequestHandler stats are now persistent, and will no longer reset on reload.
If I understand this correctly, then I don't think we want to do this. Perhaps
I don't understand it correctly?
There needs to be a way to reset the statistics to zero. Reloading the core is
currently the way that I do this. (I'm not running cloud)
> Use Metrics library for core metrics
> ------------------------------------
>
> Key: SOLR-8785
> URL: https://issues.apache.org/jira/browse/SOLR-8785
> Project: Solr
> Issue Type: Improvement
> Affects Versions: 4.1
> Reporter: Jeff Wartes
> Labels: patch, patch-available
>
> The Metrics library (https://dropwizard.github.io/metrics/3.1.0/) is a
> well-known way to track metrics about applications.
> In SOLR-1972, latency percentile tracking was added. The comment list is
> long, so here’s my synopsis:
> 1. An attempt was made to use the Metrics library
> 2. That attempt failed due to a memory leak in Metrics v2.1.1
> 3. Large parts of Metrics were then copied wholesale into the
> org.apache.solr.util.stats package space and that was used instead.
> Copy/pasting Metrics code into Solr may have been the correct solution at the
> time, but I submit that it isn’t correct any more.
> The leak in Metrics was fixed even before SOLR-1972 was released, and by
> copy/pasting a subset of the functionality, we miss access to other important
> things that the Metrics library provides, particularly the concept of a
> Reporter. (https://dropwizard.github.io/metrics/3.1.0/manual/core/#reporters)
> Further, Metrics v3.0.2 is already packaged with Solr anyway, because it’s
> used in two contrib modules. (map-reduce and morphines-core)
> I’m proposing that:
> 1. Metrics as bundled with Solr be upgraded to the current v3.1.2
> 2. Most of the org.apache.solr.util.stats package space be deleted outright,
> or gutted and replaced with simple calls to Metrics. Due to the copy/paste
> origin, the concepts should mostly map 1:1.
> I’d further recommend a usage pattern like:
> SharedMetricRegistries.getOrCreate(System.getProperty(“solr.metrics.registry”,
> “solr-registry”))
> There are all kinds of areas in Solr that could benefit from metrics tracking
> and reporting. This pattern allows diverse areas of code to track metrics
> within a single, named registry. This well-known-name then becomes a handle
> you can use to easily attach a Reporter and ship all of those metrics off-box.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
