[
https://issues.apache.org/jira/browse/SOLR-9648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15602256#comment-15602256
]
Keith Laban commented on SOLR-9648:
-----------------------------------
Hi christine let me try to address each of these
bq. currently force-merge happens only when externally triggered
true
bq. the force-merge behaviour added by the wrap is (proposed to be) executed
only on startup
this is just where force merge is explicitly called in an effort to upgrade
segments
bq. the configured merge policy could (at least theoretically) disallow force
merges
not true, this implementation will fall through to the delegate if there are no
segments to upgrade
----
bq. The {{MAX_UPGRADES_AT_A_TIME = 5;}} sounds similar to what the
MergeScheduler does (unless merge-on-startup bypasses the merge scheduler
somehow?)
not sure if force merge abides by the MergeScheduler
bq. IndexWriter has a UNBOUNDED_MAX_MERGE_SEGMENTS==-1 which if made
non-private could perhaps be used in the cmd.maxOptimizeSegments =
Integer.MAX_VALUE;
could be an interesting approach
bq. UpgradeIndexMergePolicy also sounds very similar actually.
I saw this but chose not to use it because the implementation doesn't fallback
to the delegating merge policy.
bq. The SolrMergePolicy has no solr dependencies, might it be renamed to
something else and be part of the lucene code base?
That is true right now, but I hope we can use the same approach to add in hooks
for other solr specifc things if we need later. And hopefully also use this for
things like adding/removing docvalues when the schema changes
> Wrap all solr merge policies with SolrMergePolicy
> -------------------------------------------------
>
> Key: SOLR-9648
> URL: https://issues.apache.org/jira/browse/SOLR-9648
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Keith Laban
> Attachments: SOLR-9648-WIP.patch
>
>
> Wrap the entry point for all merge policies with a single entry point merge
> policy for more fine grained control over merging with minimal configuration.
> The main benefit will be to allow upgrading of segments on startup when
> lucene version changes. Ideally we can use the same approach for adding and
> removing of doc values when the schema changes and hopefully other index type
> changes such as Trie -> Point types, or even analyzer changes.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
