[
https://issues.apache.org/jira/browse/SOLR-9660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15608688#comment-15608688
]
Judith Silverman commented on SOLR-9660:
----------------------------------------
Ah, glad you found that bug.
While I was looking for it, I noticed that in at least three different files
(Grouping.java, TopGroupsShardRequestFactory.java,
TopGroupsShardResponseProcessor.java), we set something related to groupOffset
to 0 if group.format == simple or groupingSpec.isMain(). I certainly don't see
the whole picture, but other things being equal I would think it cleaner and
safer to do that check as far upstream and in as few places as possible.
Is there any advantage to having so many '5's in the unit tests, by the way?
Seems to me that two of them could get swapped and the test rig would never
know.
Thanks,
Judith
> in GroupingSpecification factor [group](sort|offset|limit) into
> [group](sortSpec)
> ---------------------------------------------------------------------------------
>
> Key: SOLR-9660
> URL: https://issues.apache.org/jira/browse/SOLR-9660
> Project: Solr
> Issue Type: Task
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Christine Poerschke
> Assignee: Christine Poerschke
> Priority: Minor
> Attachments: SOLR-9660.patch, SOLR-9660.patch
>
>
> This is split out and adapted from and towards the SOLR-6203 changes.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
