[ 
https://issues.apache.org/jira/browse/LUCENE-3058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13028104#comment-13028104
 ] 

Dawid Weiss commented on LUCENE-3058:
-------------------------------------

Looks good to me. One note: possible NPE here (null passes all instanceofs):
{code}
+    @Override
+    public boolean equals(Object _other) {
+      if (_other instanceof TwoLongs) {
+        final TwoLongs other = (TwoLongs) _other;
+        return first == other.first && second == other.second;
+      } else {
+        return false;
+      }
+    }
{code}

> FST should allow more than one output for the same input
> --------------------------------------------------------
>
>                 Key: LUCENE-3058
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3058
>             Project: Lucene - Java
>          Issue Type: Improvement
>            Reporter: Michael McCandless
>            Assignee: Michael McCandless
>             Fix For: 4.0
>
>         Attachments: LUCENE-3058.patch, LUCENE-3058.patch
>
>
> For the block tree terms dict, it turns out I need this case.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to