That'd be great, thanks :) Yes, let's iterate on the issue! But: it should still be open, I hope (I didn't mean to close it yet, since it's not back ported)...
Mike http://blog.mikemccandless.com On Tue, May 3, 2011 at 5:51 AM, Shai Erera <ser...@gmail.com> wrote: > Mike, if you want, I can back-port it, as I've already started this when > preparing the patch. > > I noticed that you added a "throws IOE" to IW.setInfoStream -- is it ok on > 3x too? It'll be a backwards change. > > Maybe we should iterate on the issue? I can reopen. > > Shai > > On Tue, May 3, 2011 at 12:36 PM, Michael McCandless > <luc...@mikemccandless.com> wrote: >> >> Looks good Shai! >> >> Comments below too: >> >> On Tue, May 3, 2011 at 5:29 AM, Shai Erera <ser...@gmail.com> wrote: >> > Hi >> > >> > I looked into porting it to 3x, and prepared the attached patch. It only >> > contains the new TieredMP and Test, as well as the necessary changes to >> > LuceneTestCase and IndexWriter. I guess you can start with it (even just >> > the >> > MP and IW changes) to test it on your indexes. >> > >> > Mike, I saw that there were many more changes, as part of LUCENE-1076, >> > done >> > to the code. In particular, this MP is now the default (on trunk), so I >> > guess many changes (to tests) were needed because of that. Do you >> > remember, >> > if apart from the changes I've included in the patch, other important >> > changes w.r.t. this code? >> >> The only other changes I can think of were some verbosity improvements >> to IndexWriter, to support the python script that can make a merge >> movie from an infoStream output; but that can wait for when I >> back-port to 3.x... >> >> > As we won't change the default MP on 3x, I'm guessing I don't need to >> > port >> > all the changes to 3x. >> >> Right, I think. >> >> Mike >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org >> For additional commands, e-mail: dev-h...@lucene.apache.org >> > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
