[ 
https://issues.apache.org/jira/browse/SOLR-9729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15636738#comment-15636738
 ] 

Kevin Risden commented on SOLR-9729:
------------------------------------

Well now I'm confused. I really think that JDBCStream should be using 
getColumnLabel since that makes AS queries work correctly. The hsqldb 
get_column_name parameter seems to be able to change that behavior which 
doesn't make sense. The default value of true is correct. I think the tests 
need to be fixed to not rely on get_column_name.

> JDBCStream improvements
> -----------------------
>
>                 Key: SOLR-9729
>                 URL: https://issues.apache.org/jira/browse/SOLR-9729
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Kevin Risden
>            Assignee: Kevin Risden
>            Priority: Minor
>             Fix For: 6.4
>
>         Attachments: SOLR-9729.patch
>
>
> JDBCStream has a few items that can be improved:
> * IOExceptions don't have the expression in the message
> * Use .equals() when comparing class names



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to