[
https://issues.apache.org/jira/browse/SOLR-9659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15644522#comment-15644522
]
Erick Erickson commented on SOLR-9659:
--------------------------------------
Progress not perfection. I was puzzled a bit by the fact that this code is all
additions, then saw the line "The follow-up patch is a lot bigger".
My vote would be to go ahead and commit this and the follow-up. I can imagine
we tailor the API going forward to make switching over to Curator easier
"sometime". Meanwhile if we get something that consolidates scattered complex
code that's a win. And having the complex code in _one_ place is a big win IMO.
> Add zookeeper DataWatch API
> ---------------------------
>
> Key: SOLR-9659
> URL: https://issues.apache.org/jira/browse/SOLR-9659
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Alan Woodward
> Assignee: Alan Woodward
> Attachments: SOLR-9659.patch
>
>
> We have several components which need to set up watches on ZooKeeper nodes
> for various aspects of cluster management. At the moment, all of these
> components do this themselves, leading to large amounts of duplicated code,
> and complicated logic for dealing with reconnections, etc, scattered across
> the codebase. We should replace this with a simple API controlled by
> SolrZkClient, which should make the code more robust, and testing
> considerably easier.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
