[
https://issues.apache.org/jira/browse/LUCENE-7544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15645655#comment-15645655
]
ASF GitHub Bot commented on LUCENE-7544:
----------------------------------------
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/111#discussion_r86882518
--- Diff:
lucene/highlighter/src/test/org/apache/lucene/search/uhighlight/TestUnifiedHighlighter.java
---
@@ -959,4 +961,84 @@ protected PassageFormatter getFormatter(String field) {
ir.close();
}
+ public void testBooleanWithSpanAndOverlappingTerms() throws IOException {
--- End diff --
Can you please simplify this one... it's ultimately testing
preSpanQueryRewrite... maybe make it clear that it's testing that by naming the
test method as-such? Maybe this test should go into
TestUnifiedHighlighterStrictPhrases as it's pertinent to that and not general
stuff.
> UnifiedHighlighter should allow extension for custom query types
> ----------------------------------------------------------------
>
> Key: LUCENE-7544
> URL: https://issues.apache.org/jira/browse/LUCENE-7544
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/highlighter
> Reporter: Michael Braun
> Assignee: David Smiley
> Fix For: 6.4
>
>
> In our use case, we have custom query types (both SpanQuery and
> non-SpanQuery) which are not provided by Lucene. UnifiedHighlighter needs
> extension points to handle some custom query types in order for highlighting
> to be accurate. This issue represents adding two extension point methods to
> support custom query types.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
