[
https://issues.apache.org/jira/browse/SOLR-9746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15657885#comment-15657885
]
Christine Poerschke commented on SOLR-9746:
-------------------------------------------
bq. ... I'd suggest to rename the packages in ltr to have "ltr" in its name. ...
>> Done.
bq. ... If the package names are the same to work around package-protected
access ...
>> The package names were made the same only with the intention that then no
>> solrconfig.xml changes would be required if ltr graduates from solr/contrib
>> to solr/core. However, the same effect should similarly so be achievable and
>> more clearly so via something like this as part of graduation
{code}
# solr/contrib/.../LTRQParserPlugin.java
package org.apache.solr.ltr.search;
- public class LTRQParserPlugin extends QParserPlugin implements ... {
- ...
- }
+ @Deprecated // use {@link org.apache.solr.search.LTRQParserPlugin} instead
+ public class LTRQParserPlugin extends org.apache.solr.search.LTRQParserPlugin
{
+ }
+ #solr/core/.../LTRQParserPlugin.java
+ package org.apache.solr.search;
+ public class LTRQParserPlugin extends QParserPlugin implements ... {
+ ...
+ }
{code}
bq. ... I know we have some modules in Lucene that also share packages, but we
should work on fixing them. ...
>> Interesting. I had a quick look around but couldn't find obvious examples,
>> assuming {{.../abc/util}} and {{.../xyz/util}} would be considered to not
>> share? If it doesn't exist already, shall we create a list of modules that
>> would need attention then?
> Eclipse project broken due to duplicate package-info.java in LTR contrib
> ------------------------------------------------------------------------
>
> Key: SOLR-9746
> URL: https://issues.apache.org/jira/browse/SOLR-9746
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Ishan Chattopadhyaya
> Assignee: Christine Poerschke
> Priority: Minor
>
> The eclipse project generated through {{ant eclipse}} seems to be broken,
> since there are errors complaining duplicate resources. The problem is that
> the following files have the same package and class names:
> {code}
> ./solr/core/src/java/org/apache/solr/response/transform/package-info.java
> ./solr/contrib/ltr/src/java/org/apache/solr/response/transform/package-info.java
> ./solr/core/src/java/org/apache/solr/search/package-info.java
> ./solr/contrib/ltr/src/java/org/apache/solr/search/package-info.java
> {code}
> Not sure if the idea project is affected.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
