Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/107#discussion_r87743142
--- Diff:
solr/core/src/java/org/apache/solr/highlight/DefaultSolrHighlighter.java ---
@@ -373,6 +373,11 @@ protected BoundaryScanner getBoundaryScanner(String
fieldName, SolrParams params
if (!isHighlightingEnabled(params)) // also returns early if no unique
key field
return null;
+ boolean rewrite = query != null &&
!(Boolean.valueOf(params.get(HighlightParams.USE_PHRASE_HIGHLIGHTER, "true")) &&
--- End diff --
no biggie but I think a simple if(...) condition would be simpler; no
variable.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
