[
https://issues.apache.org/jira/browse/SOLR-9708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15662936#comment-15662936
]
David Smiley commented on SOLR-9708:
------------------------------------
_(see github comments)_
Looking good Tim; just some super minor stuff.
It's unfortunate that users need to go into their solrconfig to enable this
highlighter. What if there was a boolean param {{hl.useUnifiedHighlighter}}
that was evaluated at the very beginning of
{{DefaultSolrHighlighter.doHighlighting}} that delegated to it? I know from a
code perspective it's _very_ hacky but consider the user experience. In Solr
we're trying to push towards avoiding the need to touch configs. Fortunately,
this highlighter is completely configured from params (not so for SH & FVH)...
except for enabling it in the first place (which we can change here). The DSH
after all already handles FVH. In a future issue for 7.0 I'd like to propose
some re-arrangement to the Solr highlighting code to simplify & clean up things.
> Expose UnifiedHighlighter in Solr
> ---------------------------------
>
> Key: SOLR-9708
> URL: https://issues.apache.org/jira/browse/SOLR-9708
> Project: Solr
> Issue Type: New Feature
> Security Level: Public(Default Security Level. Issues are Public)
> Components: highlighter
> Reporter: Timothy M. Rodriguez
> Assignee: David Smiley
> Fix For: 6.4
>
>
> This ticket is for creating a Solr plugin that can utilize the new
> UnifiedHighlighter which was initially committed in
> https://issues.apache.org/jira/browse/LUCENE-7438
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
