[
https://issues.apache.org/jira/browse/SOLR-9772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15668237#comment-15668237
]
ASF GitHub Bot commented on SOLR-9772:
--------------------------------------
GitHub user johnthcall opened a pull request:
https://github.com/apache/lucene-solr/pull/115
SOLR-9772 FieldSortValues should reuse comparator and only invalidate
leafComparator
No need to recreate the comparator as leaf changes. There was a bug where
lastIdx was not set and was recreating the comparator and re-initializing the
leafComparator for each document.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/johnthcall/lucene-solr patch-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/lucene-solr/pull/115.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #115
----
commit 8a47601e0f42563c1d45c3049d21194505b1a89d
Author: John Call <johnc...@microsoft.com>
Date: 2016-11-15T20:37:37Z
SOLR-9772 FieldSortValues should reuse comparator and only invalidate
leafComparator
----
> FieldSortValues should reuse comparator and only invalidate leafComparator
> --------------------------------------------------------------------------
>
> Key: SOLR-9772
> URL: https://issues.apache.org/jira/browse/SOLR-9772
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: search
> Affects Versions: master (7.0)
> Reporter: John Call
> Priority: Minor
> Fix For: master (7.0)
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> In QueryComponent.doFieldSortValues when there are multiple leafs a
> comparator and leafComparator is made for each document instead of creating a
> common comparator and making as different leafs are visited.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
