[
https://issues.apache.org/jira/browse/LUCENE-7466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15670066#comment-15670066
]
Tommaso Teofili commented on LUCENE-7466:
-----------------------------------------
thanks [~ypeilin] for your patch, here're a couple of comments:
- I think a testcase for all the added models should be provided in order to
make sure they work as expected
- the changes to {{NumericDocValues}}, {{FloatDocValues}} and
{{DoubleDocValues}} break some tests as it seems NDV always returns a _Long_
while FDV and DDV convert such a _Long_ value to an _Integer_ and then back to
a _Float_ / _Double_ using _Float.intBitsToFloat_ / _Double.intBitsToDouble_,
can you clarify if / why is that needed for axiomatic similarity ? (if I remove
the mentioned changes all the tests pass but then I'm not sure if that has an
impact on the Axiomatic similarities because of the missing tests)
> add axiomatic similarity
> -------------------------
>
> Key: LUCENE-7466
> URL: https://issues.apache.org/jira/browse/LUCENE-7466
> Project: Lucene - Core
> Issue Type: Improvement
> Components: core/search
> Affects Versions: master (7.0)
> Reporter: Peilin Yang
> Assignee: Tommaso Teofili
> Labels: patch
>
> Add axiomatic similarity approaches to the similarity family.
> More details can be found at http://dl.acm.org/citation.cfm?id=1076116 and
> https://www.eecis.udel.edu/~hfang/pubs/sigir05-axiom.pdf
> There are in total six similarity models. All of them are based on BM25,
> Pivoted Document Length Normalization or Language Model with Dirichlet prior.
> We think it is worthy to add the models as part of Lucene.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
