[
https://issues.apache.org/jira/browse/LUCENE-7521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15690275#comment-15690275
]
Yonik Seeley commented on LUCENE-7521:
--------------------------------------
The rational for this patch looked to be "most specializations we have are
barely used for performance-sensitive operations".
I would definitely categorize FieldCache usage in Solr as
performance-sensitive, so I thought maybe you were only talking about usage in
Lucene (since the FieldCache was recently moved from Solr to Lucene). Is this
the case?
In the interests of being data-driven, it seemed like the approach should be to
either:
1) benchmark solr's fieldcache usage w/o Direct* and Packed*ThreeBlocks impls
and see what the impact is
2) make a copy of PackedInts in Solr (and use it in the FieldCache) so Lucene
can immediately simplify PackedInts w/o regard for FieldCache (#1 could still
be done at a later time)
> Simplify PackedInts
> -------------------
>
> Key: LUCENE-7521
> URL: https://issues.apache.org/jira/browse/LUCENE-7521
> Project: Lucene - Core
> Issue Type: Task
> Reporter: Adrien Grand
> Priority: Minor
> Attachments: LUCENE-7521.patch
>
>
> We have a lot of specialization in PackedInts about how to keep packed arrays
> of longs in memory. However, most use-cases have slowly moved to DirectWriter
> and DirectMonotonicWriter and most specializations we have are barely used
> for performance-sensitive operations, so I'd like to clean this up a bit.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
