[
https://issues.apache.org/jira/browse/LUCENE-7564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15690933#comment-15690933
]
Steve Rowe commented on LUCENE-7564:
------------------------------------
My Jenkins found a non-reproducing master seed for a
{{AnalyzingInfixSuggester.testRandomNRT()}} failure - I'm looking into it:
{noformat}
[junit4] Suite:
org.apache.lucene.search.suggest.analyzing.AnalyzingInfixSuggesterTest
[junit4] 2> ????? ?????? 23, 2016 10:32:50 ?
com.carrotsearch.randomizedtesting.RandomizedRunner$QueueUncaughtExceptionsHandler
uncaughtException
[junit4] 2> WARNING: Uncaught exception in thread:
Thread[Thread-1,5,TGRP-AnalyzingInfixSuggesterTest]
[junit4] 2> org.apache.lucene.store.AlreadyClosedException: this
ReferenceManager is closed
[junit4] 2> at
__randomizedtesting.SeedInfo.seed([32DB11C1C6E723F0]:0)
[junit4] 2> at
org.apache.lucene.search.ReferenceManager.acquire(ReferenceManager.java:98)
[junit4] 2> at
org.apache.lucene.search.suggest.analyzing.AnalyzingInfixSuggester.lookup(AnalyzingInfixSuggester.java:645)
[junit4] 2> at
org.apache.lucene.search.suggest.analyzing.AnalyzingInfixSuggester.lookup(AnalyzingInfixSuggester.java:457)
[junit4] 2> at
org.apache.lucene.search.suggest.analyzing.AnalyzingInfixSuggesterTest$LookupThread.run(AnalyzingInfixSuggesterTest.java:533)
[junit4] 2>
[junit4] 2> NOTE: reproduce with: ant test
-Dtestcase=AnalyzingInfixSuggesterTest -Dtests.method=testRandomNRT
-Dtests.seed=32DB11C1C6E723F0 -Dtests.slow=true -Dtests.locale=ar-SY
-Dtests.timezone=America/Bahia_Banderas -Dtests.asserts=true
-Dtests.file.encoding=US-ASCII
[junit4] ERROR 6.37s J4 | AnalyzingInfixSuggesterTest.testRandomNRT <<<
[junit4] > Throwable #1:
com.carrotsearch.randomizedtesting.UncaughtExceptionError: Captured an uncaught
exception in thread: Thread[id=24, name=Thread-1, state=RUNNABLE,
group=TGRP-AnalyzingInfixSuggesterTest]
[junit4] > at
__randomizedtesting.SeedInfo.seed([32DB11C1C6E723F0:96F51F7C9E38FF4C]:0)
[junit4] > Caused by: org.apache.lucene.store.AlreadyClosedException:
this ReferenceManager is closed
[junit4] > at
__randomizedtesting.SeedInfo.seed([32DB11C1C6E723F0]:0)
[junit4] > at
org.apache.lucene.search.ReferenceManager.acquire(ReferenceManager.java:98)
[junit4] > at
org.apache.lucene.search.suggest.analyzing.AnalyzingInfixSuggester.lookup(AnalyzingInfixSuggester.java:645)
[junit4] > at
org.apache.lucene.search.suggest.analyzing.AnalyzingInfixSuggester.lookup(AnalyzingInfixSuggester.java:457)
[junit4] > at
org.apache.lucene.search.suggest.analyzing.AnalyzingInfixSuggesterTest$LookupThread.run(AnalyzingInfixSuggesterTest.java:533)
[junit4] 2> NOTE: test params are:
codec=DummyCompressingStoredFields(storedFieldsFormat=CompressingStoredFieldsFormat(compressionMode=DUMMY,
chunkSize=32445, maxDocsPerChunk=183, blockSize=695),
termVectorsFormat=CompressingTermVectorsFormat(compressionMode=DUMMY,
chunkSize=32445, blockSize=695)), sim=RandomSimilarity(queryNorm=false): {},
locale=ar-SY, timezone=America/Bahia_Banderas
[junit4] 2> NOTE: Linux 4.1.0-custom2-amd64 amd64/Oracle Corporation
1.8.0_77 (64-bit)/cpus=16,threads=1,free=390558656,total=525860864
[junit4] 2> NOTE: All tests run in this JVM: [TestWordBreakSpellChecker,
AnalyzingInfixSuggesterTest]
[junit4] Completed [32/32 (1!)] on J4 in 9.39s, 22 tests, 1 error <<<
FAILURES!
{noformat}
I'm beasting the test now with the above seed to see if I can get it to fail.
> AnalyzingInfixSuggester should close its IndexWriter by default at the end of
> build()
> -------------------------------------------------------------------------------------
>
> Key: LUCENE-7564
> URL: https://issues.apache.org/jira/browse/LUCENE-7564
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Steve Rowe
> Assignee: Steve Rowe
> Fix For: master (7.0), 6.4
>
> Attachments: LUCENE-7564.patch, LUCENE-7564.patch
>
>
> From SOLR-6246, where AnalyzingInfixSuggester's write lock on its index is
> causing trouble when reloading a Solr core:
> [~gsingers] wrote:
> bq. One suggestion that might minimize the impact: close the writer after
> build
> [~varunthacker] wrote:
> {quote}
> This is what I am thinking -
> Create a Lucene issue in which {{AnalyzingInfixSuggester#build}} closes the
> writer by default at the end.
> The {{add}} and {{update}} methods call {{ensureOpen}} and those who do
> frequent real time updates directly via lucene won't see any slowdowns.
> [~mikemccand] - Would this approach have any major drawback from Lucene's
> perspective? Else I can go ahead an tackle this in a Lucene issue
> {quote}
> [~mikemccand] wrote:
> bq. Fixing {{AnalyzingInfixSuggester}} to close the writer at the end of
> build seems reasonable?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
