[ 
https://issues.apache.org/jira/browse/LUCENE-7577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15708455#comment-15708455
 ] 

Robert Muir commented on LUCENE-7577:
-------------------------------------

i think these shit-slow queries should keep their own caching? PrefixCodedTerms 
is supposed to be an impl detail of indexwriter.

adding complexity to it over time, i dunno, is it really the right thing? The 
benefit is what, slightly speeding up crappy queries like TermsQuery at the 
risk of breaking indexwriter?

Just not sure that's really the right way to go. This is the danger of 
oversharing.

> PrefixCodedTerms should cache its hash code
> -------------------------------------------
>
>                 Key: LUCENE-7577
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7577
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Adrien Grand
>            Assignee: Adrien Grand
>            Priority: Minor
>         Attachments: LUCENE-7577.patch
>
>
> We have several queries that cache the hashcode of a PrefixCodedTerms 
> instance on top of it, so we could simplify by moving the caching to 
> PrefixCodedTerms directly.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to