[ 
https://issues.apache.org/jira/browse/SOLR-9822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15719247#comment-15719247
 ] 

David Smiley commented on SOLR-9822:
------------------------------------

In FacetFieldProcessorByArrayDV.collectCounts, the lambda leads with {{if (ord 
>= 0)}} but why would it ever be less?  Even if it is superfluous, I doubt 
removing that would help.  I like the approach with the lambdas but it's a 
shame it isn't fast.  I'm skeptical there's something we're missing to make 
this approach faster; I suspect HotSpot wants to see the loop and code it calls 
clearly without some generic indirection point (be it a marker interface or 
lambda; whatever).

I'm more interested in faceting performance _without_ the FieldCache as I hope 
users use it less and less.  I think FC should be opt-in explicitly.  

> Improve faceting performance with FieldCache
> --------------------------------------------
>
>                 Key: SOLR-9822
>                 URL: https://issues.apache.org/jira/browse/SOLR-9822
>             Project: Solr
>          Issue Type: Sub-task
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: Facet Module
>            Reporter: Yonik Seeley
>            Assignee: Yonik Seeley
>             Fix For: master (7.0)
>
>         Attachments: SOLR-9822.patch, SOLR-9822_lambda.patch
>
>
> This issue will try to specifically address the performance regressions of 
> faceting on FieldCache fields observed in SOLR-9599.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to