[
https://issues.apache.org/jira/browse/LUCENE-7575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15722472#comment-15722472
]
David Smiley commented on LUCENE-7575:
--------------------------------------
This is looking really good now Jim! I like this Predicate<String> approach.
UH:
* Maybe change UH.extractTerms to simply be a Set (HashSet) since we needn't
pay any sorting expense up front any longer.
* couldn't defaultFieldMatcher be initialized to non-null to match the same
field? Then getFieldMatcher() would simply return it.
PhraseHelper:
* the comment on the fieldName field about being non-null isn't true anymore;
in fact it's required. Perhaps add Objects.requireNonNull(...) in c'tor if you
want.
* I can see why you changed FieldFilteringTermHashSet to extend TreeSet. But
you now need to modify the javadocs & class name accordingly; perhaps removing
the implementation detail like this
Nice tests. That's it.
> UnifiedHighlighter: add requireFieldMatch=false support
> -------------------------------------------------------
>
> Key: LUCENE-7575
> URL: https://issues.apache.org/jira/browse/LUCENE-7575
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/highlighter
> Reporter: David Smiley
> Assignee: David Smiley
> Attachments: LUCENE-7575.patch, LUCENE-7575.patch
>
>
> The UnifiedHighlighter (like the PostingsHighlighter) only supports
> highlighting queries for the same fields that are being highlighted. The
> original Highlighter and FVH support loosening this, AKA
> requireFieldMatch=false.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
