[
https://issues.apache.org/jira/browse/LUCENE-7586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15732509#comment-15732509
]
Uwe Schindler commented on LUCENE-7586:
---------------------------------------
I don't fully understand the issue description. The issue you enabled precommit
checks for is only catched by Eclipse compiler. The warning list by Jenkins is
produced on Javac's output - so how does that relate to each other?
I agree we should primarily fix the Oracle Javac warnings (mostly rawtypes or
unsafe casts and a few try-resources and fall-through warnings), but I can also
work on enabling warning reports for the eclipse compiler on Policeman Jenkins.
But making it a failure for some cases (as you did) is also fine.
> fail precommit on varargsArgumentNeedCast
> -----------------------------------------
>
> Key: LUCENE-7586
> URL: https://issues.apache.org/jira/browse/LUCENE-7586
> Project: Lucene - Core
> Issue Type: Task
> Reporter: Christine Poerschke
> Assignee: Christine Poerschke
> Priority: Minor
> Attachments: LUCENE-7586.patch
>
>
> Why this, why now?
> I had noticed the Java Warnings (listing and trend chart) on [~thetaphi]'s
> https://jenkins.thetaphi.de/job/Lucene-Solr-master-Linux/ and after fixing
> one really easy warning got curious about others of the same category. There
> aren't any and so it would seem obvious to update the precommit checks (and
> Eclipse settings) to prevent future introductions.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
