[
https://issues.apache.org/jira/browse/SOLR-9839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15733025#comment-15733025
]
Mike Drob commented on SOLR-9839:
---------------------------------
Looks like SystemPropertiesRestoreRule is automatically applied to everything
inheriting from SolrTestCaseJ4. In which case, it would still be nice to remove
the manual resetting from a bunch of out test cases. In light of this, I still
think the code change is fine as is.
The commit message in the patch references the wrong JIRA. [~erickerickson] -
is there anything else that you think needs to be changed?
> Use 'useFactory' in tests instead of setting manually
> -----------------------------------------------------
>
> Key: SOLR-9839
> URL: https://issues.apache.org/jira/browse/SOLR-9839
> Project: Solr
> Issue Type: Test
> Security Level: Public(Default Security Level. Issues are Public)
> Components: Tests
> Reporter: Mike Drob
> Priority: Minor
> Attachments: SOLR-9839.patch
>
>
> We have several tests that will explicitly set a directory factory via
> SysProp, some of which forget to unset it.
> We should use {{useFactory}} so that we can benefit from the call to
> {{resetFactory}} in {{SolrTestCaseJ4.teardownTestCases}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
