[
https://issues.apache.org/jira/browse/LUCENE-7590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15747731#comment-15747731
]
Adrien Grand commented on LUCENE-7590:
--------------------------------------
Thanks, the missing change and the rename look good to me.
Regarding DocValuesIterator, I think in the simple text case, it is really an
impl detail, and the one in core is only really used to share the declaration
of {{advanceExact}}. My feeling is that making it public is only useful here
because the way stats are computed is very abstracted with generics and
inheritance, so I am not convinced this use-case requires that we make
DocValuesIterator public. I would rather either avoid abstracting so much or
define a functional interface in the stats package that only defines an
advanceExact method and use method references to be able to share computation
across the various doc value types.
Maybe we can also make the collector pkg-private, it does not seem to need to
be public, does it?
> Add DocValues statistics helpers
> --------------------------------
>
> Key: LUCENE-7590
> URL: https://issues.apache.org/jira/browse/LUCENE-7590
> Project: Lucene - Core
> Issue Type: New Feature
> Components: modules/misc
> Reporter: Shai Erera
> Assignee: Shai Erera
> Attachments: LUCENE-7590.patch, LUCENE-7590.patch, LUCENE-7590.patch,
> LUCENE-7590.patch, LUCENE-7590.patch, LUCENE-7590.patch
>
>
> I think it can be useful to have DocValues statistics helpers, that can allow
> users to query for the min/max/avg etc. stats of a DV field. In this issue
> I'd like to cover numeric DV, but there's no reason not to add it to other DV
> types too.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
