[
https://issues.apache.org/jira/browse/SOLR-7115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15758997#comment-15758997
]
Yonik Seeley commented on SOLR-7115:
------------------------------------
I tried out the modified test, and as expected it passes (since exceptions are
no longer thrown on a commit). I'm not going to commit it because the test is
no longer really testing anything anymore (since it requires exceptions that
are no longer thrown), and other tests cover concurrent commits.
> UpdateLog can miss closing transaction log objects.
> ---------------------------------------------------
>
> Key: SOLR-7115
> URL: https://issues.apache.org/jira/browse/SOLR-7115
> Project: Solr
> Issue Type: Bug
> Reporter: Mark Miller
> Assignee: Yonik Seeley
> Fix For: 6.x, master (7.0)
>
> Attachments: SOLR-7115-LargeVolumeEmbeddedTest-fail.txt,
> SOLR-7115.patch, SOLR-7115.patch, tests-failures-7115.txt
>
>
> I've seen this happen on YourKit and in various tests - especially since
> adding resource release tracking to the log objects. Now I've got a test that
> catches it in SOLR-7113.
> It seems that in precommit, if prevTlog is not null, we need to close it
> because we are going to overwrite prevTlog with a new log.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
