Jaechang Nam created SOLR-9878:
----------------------------------
Summary: Code smell in if statement
Key: SOLR-9878
URL: https://issues.apache.org/jira/browse/SOLR-9878
Project: Solr
Issue Type: Bug
Security Level: Public (Default Security Level. Issues are Public)
Reporter: Jaechang Nam
Priority: Trivial
In recent code snapshot (Github mirror's commit id:
c8542b2bd0470af9f8d64bb8133f31828b342604 as today), there is an illogical
condition that can be a code smell or a potential bug:
ReversedWildcardFilterFactory fac = leadingWildcards.get(fieldType);
if (fac != null || leadingWildcards.containsKey(fac)) {
return fac;
}
In SOLR-3492, it said there was a fix in SOLR-4093. However, the fix still has
an issue as above: containsKey will always have null in this if statement. The
second condition could be unnecessary. Does leadingWildcards allow a null
object as a key? If so, it will return null that might cause NPE.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
