[ 
https://issues.apache.org/jira/browse/LUCENE-7602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15779059#comment-15779059
 ] 

Paul Elschot edited comment on LUCENE-7602 at 12/26/16 10:06 PM:
-----------------------------------------------------------------

bq. can't we just use Map<Object,Object> ?

ContextMap implements that interface.
Since this is widely used, I prefer to use a lucene class (ContextMap) over an 
interface that is defined in the java language (Map<Object,Object>), because it 
allows a change in a single place.

We could still separate the implementation from the interface, but that would 
be more than fixing the compiler warnings here.




was (Author: paul.elsc...@xs4all.nl):
bq. can't we just use Map<Object,Object> ?

ContextMap implements that interface.
Since this is widely used, I prefer use a lucene class class (ContextMap) over 
an interface that is defined in the java language (Map<Object,Object>), because 
it allows a change in a single place.

We could still separate the implementation from the interface, but that would 
be more than fixing the compiler warnings here.



> Fix compiler warnings for ant clean compile
> -------------------------------------------
>
>                 Key: LUCENE-7602
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7602
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Paul Elschot
>            Priority: Minor
>              Labels: build
>             Fix For: trunk
>
>         Attachments: LUCENE-7602-ContextMap-lucene.patch, 
> LUCENE-7602-ContextMap-solr.patch, LUCENE-7602.patch, LUCENE-7602.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to