[
https://issues.apache.org/jira/browse/LUCENE-7602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Paul Elschot updated LUCENE-7602:
---------------------------------
Attachment: LUCENE-7602.patch
Patch of 29 Dec 2016.
This patch takes tries to separate interface from implementation by making the
constructors in ContextMap and QueryContext protected and using only a few
factory methods for ContextMap.
It would be nicer to use private inheritance from HashMap<Object,Object> and
only expose Map<Object,Object>, but java does not have private inheritance. The
alternative of object composition gives a detour to AbstractMap, and that only
complicates the code.
So the question is which is preferable: use of a local class ContextMap as in
the patch, or use of Map<Object,Object> ?
> Fix compiler warnings for ant clean compile
> -------------------------------------------
>
> Key: LUCENE-7602
> URL: https://issues.apache.org/jira/browse/LUCENE-7602
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Paul Elschot
> Priority: Minor
> Labels: build
> Fix For: trunk
>
> Attachments: LUCENE-7602-ContextMap-lucene.patch,
> LUCENE-7602-ContextMap-solr.patch, LUCENE-7602.patch, LUCENE-7602.patch,
> LUCENE-7602.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
