[ 
https://issues.apache.org/jira/browse/SOLR-9886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15786306#comment-15786306
 ] 

ASF GitHub Bot commented on SOLR-9886:
--------------------------------------

GitHub user praste opened a pull request:

    https://github.com/apache/lucene-solr/pull/132

    SOLR-9886

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/praste/lucene-solr CacheConfig

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/lucene-solr/pull/132.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #132
    
----
commit c5363f6dabb0a36cc41f174023eafdd443ed106f
Author: Pushkar Raste <[email protected]>
Date:   2016-12-23T16:41:28Z

    Allow enable/disable cache

commit b8daed32047475d0eee330374d8d4ed5f2820897
Author: Pushkar Raste <[email protected]>
Date:   2016-12-29T18:20:56Z

    Merge branch 'master' of https://github.com/apache/lucene-solr into 
CacheConfig

commit e394b405b9e6fb0024c4b3a8747ec500dd5ba3d4
Author: Pushkar Raste <[email protected]>
Date:   2016-12-29T22:46:42Z

    Test case, bug fix, updated EdittableCofing.json

commit 59484c080fc3e3e97bb5a443588c409e381e1340
Author: Pushkar Raste <[email protected]>
Date:   2016-12-29T22:47:37Z

    Adding missing files

----


> Add ability to turn off/on caches 
> ----------------------------------
>
>                 Key: SOLR-9886
>                 URL: https://issues.apache.org/jira/browse/SOLR-9886
>             Project: Solr
>          Issue Type: Bug
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Pushkar Raste
>            Assignee: Noble Paul
>            Priority: Minor
>         Attachments: EnableDisableCacheAttribute.patch, SOLR-9886.patch
>
>
> There is no elegant way to turn off caches (filterCache, queryResultCache 
> etc) from the solrconfig. When I tried setting size and initialSize to zero, 
> it resulted in caches of size 2. Here is the code that overrides setting zero 
> sized cache. 
> https://github.com/apache/lucene-solr/blob/master/solr/core/src/java/org/apache/solr/search/FastLRUCache.java#L61-L73
> Only way to disable cache right now is by removing cache configs from the 
> solrConfig, but we can simply provide an attribute to disable cache, so that 
> we can override it using a system property. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to