[
https://issues.apache.org/jira/browse/SOLR-5616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15799792#comment-15799792
]
ASF subversion and git services commented on SOLR-5616:
-------------------------------------------------------
Commit b1ce385302d055e53e51f364d88482cf7e24ad6f in lucene-solr's branch
refs/heads/branch_6x from [~dpgove]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=b1ce385 ]
SOLR-5616: Simplifies grouping code to use ResponseBuilder.needDocList() to
determine if it needs to generate a doc list for grouped results.
> Make grouping code use response builder needDocList
> ---------------------------------------------------
>
> Key: SOLR-5616
> URL: https://issues.apache.org/jira/browse/SOLR-5616
> Project: Solr
> Issue Type: Bug
> Reporter: Steven Bower
> Assignee: Erick Erickson
> Fix For: 6.4
>
> Attachments: SOLR-5616.patch, SOLR-5616.patch, SOLR-5616.patch
>
>
> Right now the grouping code does this to check if it needs to generate a
> docList for grouped results:
> {code}
> if (rb.doHighlights || rb.isDebug() || params.getBool(MoreLikeThisParams.MLT,
> false) ){
> ...
> }
> {code}
> this is ugly because any new component that needs a doclist, from grouped
> results, will need to modify QueryComponent to add a check to this if.
> Ideally this should just use the rb.isNeedDocList() flag...
> Coincidentally this boolean is really never used at for non-grouped results
> it always gets generated..
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
