[
https://issues.apache.org/jira/browse/SOLR-9934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15813201#comment-15813201
]
Mike Drob commented on SOLR-9934:
---------------------------------
Thanks for giving a few examples of when the difference matters. The only other
consideration I can think of would be if the new method is potentially more
performant by virtue of using a deeper (more direct?) method. Not having
measured using JSON v XML handlers, I don't know which one could make the whole
test suite faster.
Another difference that I noticed is that we don't check for success on
{{clearIndex}} like we did on {{assertU}}, but maybe this doesn't matter.
> SolrTestCase.clearIndex should ensure IndexWriter.deleteAll is called
> ---------------------------------------------------------------------
>
> Key: SOLR-9934
> URL: https://issues.apache.org/jira/browse/SOLR-9934
> Project: Solr
> Issue Type: Test
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Hoss Man
> Assignee: Hoss Man
> Fix For: master (7.0), 6.4
>
> Attachments: SOLR-9934.patch
>
>
> Normal deleteByQuery commands are subject to version constraint checks due to
> the possibility of out of order updates, but DUH2 has special support
> (triggered by {{version=-Long.MAX_VALUE}} for use by tests to override these
> version constraints and do a low level {{IndexWriter.deleteAll()}} call. A
> handful of tests override {{SolrTestCaseJ4.clearIndex()}} to take advantage
> of this (using copy/pasted impls), but given the intended purpose/usage of
> {{SolrTestCaseJ4.clearIndex()}}, it seems like the the base method in
> {{SolrTestCaseJ4}} should itself trigger this low level deletion, so tests
> get this behavior automatically.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
