[ 
https://issues.apache.org/jira/browse/LUCENE-7624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15823102#comment-15823102
 ] 

Paul Elschot commented on LUCENE-7624:
--------------------------------------

This one is an interesting target for surround, so I had a look.

Allowing more than one field for the terms also has an advantage in that only 
one doc id set will be built for all the terms.

As to the code: 
There is a small javadoc mistake in line 54 using both "@{" and "{@".
When constructing a Term a deep copy of the given BytesRef is taken, so the 
deep copy in line 154 is superfluous.
(The deep copy in line 222 of the termEnum.term() is needed there.)

> Consider moving TermsQuery to core
> ----------------------------------
>
>                 Key: LUCENE-7624
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7624
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Alan Woodward
>            Assignee: Alan Woodward
>             Fix For: master (7.0), 6.4
>
>         Attachments: LUCENE-7624.patch
>
>
> TermsQuery current sits in the queries module, but it's used in both 
> spatial-extras and in facets, and currently is the only reason that the 
> facets module has a dependency on queries.  I think it's a generally useful 
> query, and would fit in perfectly well in core.
> This would also allow us to explore rewriting BooleanQuery to TermsQuery to 
> avoid the max-clauses limit



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to