Hello Uwe, On Sat, Jan 14, 2017 at 1:56 PM Uwe Schindler <u...@thetaphi.de> wrote:
> Hi, > > > > I fixed the compile warning. The more serious issue was a problem with > Solr and Eclipse: It did not compile anymore, because the Solr UHighlighter > implementation was using a Java-1.0-like inner class which was not nested > but just top-level in same source file. > Can you please clarify what this problem is? I thought I knew but your example doesn't match my understanding. I don't use Eclipse so it's not apparent to me. UnifiedSolrHighlighter has a static inner class SolrExtendedUnifiedHighlighter. It is an inner class; not some other class in the same source file. UnifiedHighlither (in Lucene) only has inner classes too. Maybe you meant the class FragmentQueue in Lucene Highlighter.java? I dunno. > IMHO, we should add a style check in “ant validate” to prevent this type > of class declaration. Top-Level classes should always be in separate files > or properly nested. > +1 ~ David -- Lucene/Solr Search Committer, Consultant, Developer, Author, Speaker LinkedIn: http://linkedin.com/in/davidwsmiley | Book: http://www.solrenterprisesearchserver.com
