[ https://issues.apache.org/jira/browse/SOLR-2512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13032483#comment-13032483 ]
Tommaso Teofili commented on SOLR-2512: --------------------------------------- One more thing I'd change is using StringBuilder with append() instead of String concatenation ("some string" + "another string") inside the catch block of UIMAUpdateRequestProcessor.processAdd() method (I did so in my patch) since it's more efficient. Still I'm not sure logging the first 100 chars of text is a good idea but you're right that we should maintain the schema information to know what field is the uniquekey and this would put unnecessary coupling between the two classes. > uima: add an ability to skip runtime error in AnalysisEngine > ------------------------------------------------------------ > > Key: SOLR-2512 > URL: https://issues.apache.org/jira/browse/SOLR-2512 > Project: Solr > Issue Type: Improvement > Affects Versions: 3.1 > Reporter: Koji Sekiguchi > Priority: Minor > Fix For: 3.2, 4.0 > > Attachments: SOLR-2512.patch, SOLR-2512.patch, SOLR-2512.patch > > > Currently, if AnalysisEngine throws an exception during processing a text, > whole adding docs go fail. Because online NLP services are error-prone, users > should be able to choose whether solr skips the text processing (but source > text can be indexed) for the document or throws a runtime exception so that > solr can stop adding documents entirely. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org