[
https://issues.apache.org/jira/browse/SOLR-9972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15826438#comment-15826438
]
James Dyer commented on SOLR-9972:
----------------------------------
[~cpoerschke] This looks straightforward, and I like your clean-up on existing
tests!
Just to be clear, this fixes the case of invalid json with "extended collate".
It does not break backwards-compatibility in any other way, right? Is the xml
rendering the same either way? Does solrj handle the change? (I'm pretty sure
if we broke backwards in either case, either
oas.spelling.SpellCheckCollatorTest#testExtendedCollate or
oas.client.solrj.response.TestSpellCheckResponse#testSpellCheckResponse_Extended
would fail, but its good to keep these things in mind.)
But besides being doubly sure we don't break backwards on the response format
(except for fixing the invalid json), this looks great, +1 .
> JSON-Specific Parameters arrntv causing some error for spellcheck component
> ---------------------------------------------------------------------------
>
> Key: SOLR-9972
> URL: https://issues.apache.org/jira/browse/SOLR-9972
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: Response Writers
> Affects Versions: 6.4, 6.5
> Reporter: Ricky Oktavianus Lazuardy
> Assignee: Christine Poerschke
> Priority: Minor
> Fix For: 6.5
>
> Attachments: SOLR-9972-hunch-no-test.patch, SOLR-9972.patch,
> SOLR-9972-with-test-after-SOLR-9975.patch
>
>
> So I tried using the new array named list arrntv from solr 6.5 jenkins build
> but the json returned was broken when it returned response for spellcheck
> with word break.
> for example :
> {code:javascript}
> {"name":"collation",{
> "type":"str","value":"collationQuery":"indomie kuing",
> "hits":81,
> "misspellingsAndCorrections":
> [
> {"name":"indomee","type":"str","value":"indomie"},
> {"name":"kuih","type":"str","value":"kuing"}
> ]}
> }
> {code}
> as you may see that "collationQuery":"indomie kuing" was considered as value
> thus causing the json to fail.
> i think the correct json was :
> {code:javascript}
> {"name":"collation",
> "type":"object",
> "value":{
> "collationQuery":"indomie kuing",
> "hits":81,
> "misspellingsAndCorrections":
> [
> {"name":"indomee","type":"str","value":"indomie"},
> {"name":"kuih","type":"str","value":"kuing"}
> ]}
> }
> {code}
> sorry for bad grammar english was not my first language and i know that
> object was not supported by current arrntv options.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
