[
https://issues.apache.org/jira/browse/SOLR-9972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christine Poerschke updated SOLR-9972:
--------------------------------------
Attachment: SOLR-9972-impact.out
SOLR-9972-impact
[~jdyer], thanks for the code review. I am attaching a utility shell script and
its output to try and answer your backward compat questions.
As can be seen from the output file, the impact of the _"SpellCheckComponent
collations and suggestions returned as a JSON object rather than a list"_
change here goes beyond use of {{collateExtendedResults=true}} and changes not
only some {{wt=json}} output but also some {{wt=ruby}} and {{wt=python}} output.
----
Now to the 'elephant in the room' question, if there were to be an RC2 for the
6.4.0 Solr release, would it be worth putting forward the inclusion of the
change here? I don't know enough about use of the SpellCheckComponent to have
an informed opinion on this.
[~hossman] and [~jm100] (json.nl=arrntv stakeholders from SOLR-9442 and
SOLR-9787, the json.nl=arrntv addition flagged up {{NamedList}} vs.
{{SimpleOrderedMap}} in the existing SpellCheckComponent code, similar to
SOLR-6064, the proposed fix impacts not just those using json.nl=arrntv) - if
you have any thoughts on this, please let us know. Thank you.
> JSON-Specific Parameters arrntv causing some error for spellcheck component
> ---------------------------------------------------------------------------
>
> Key: SOLR-9972
> URL: https://issues.apache.org/jira/browse/SOLR-9972
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: Response Writers
> Affects Versions: 6.4, 6.5
> Reporter: Ricky Oktavianus Lazuardy
> Assignee: Christine Poerschke
> Priority: Minor
> Fix For: 6.5
>
> Attachments: SOLR-9972-hunch-no-test.patch, SOLR-9972-impact,
> SOLR-9972-impact.out, SOLR-9972.patch,
> SOLR-9972-with-test-after-SOLR-9975.patch
>
>
> So I tried using the new array named list arrntv from solr 6.5 jenkins build
> but the json returned was broken when it returned response for spellcheck
> with word break.
> for example :
> {code:javascript}
> {"name":"collation",{
> "type":"str","value":"collationQuery":"indomie kuing",
> "hits":81,
> "misspellingsAndCorrections":
> [
> {"name":"indomee","type":"str","value":"indomie"},
> {"name":"kuih","type":"str","value":"kuing"}
> ]}
> }
> {code}
> as you may see that "collationQuery":"indomie kuing" was considered as value
> thus causing the json to fail.
> i think the correct json was :
> {code:javascript}
> {"name":"collation",
> "type":"object",
> "value":{
> "collationQuery":"indomie kuing",
> "hits":81,
> "misspellingsAndCorrections":
> [
> {"name":"indomee","type":"str","value":"indomie"},
> {"name":"kuih","type":"str","value":"kuing"}
> ]}
> }
> {code}
> sorry for bad grammar english was not my first language and i know that
> object was not supported by current arrntv options.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
