[ 
https://issues.apache.org/jira/browse/SOLR-10011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15832180#comment-15832180
 ] 

Tomás Fernández Löbbe commented on SOLR-10011:
----------------------------------------------

LGTM.
bq. We might need to refactor a bit, either now or later, to better re-use DV 
code between TrieField and PointField classes.
Either way is fine with me. I was thinking in may make sense to remove 
{{PointField.PointTypes}} and {{TrieField.TrieTypes}} and have a 
{{NumericField.Type}} that can be shared with both implementations. That would 
help this refactor, but may need to be master-only

> Non-indexed PointFields with DVs should use DocValuesRangeQuery
> ---------------------------------------------------------------
>
>                 Key: SOLR-10011
>                 URL: https://issues.apache.org/jira/browse/SOLR-10011
>             Project: Solr
>          Issue Type: Bug
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Ishan Chattopadhyaya
>         Attachments: SOLR-10011.patch, SOLR-10011.patch
>
>
> PointFields with indexed=false, docValues=true seem to be using 
> (Int|Double|Float|Long)Point.newRangeQuery() for performing exact matches and 
> range queries. However, they should instead be using DocValuesRangeQuery.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to