[
https://issues.apache.org/jira/browse/SOLR-10011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15833065#comment-15833065
]
Tomás Fernández Löbbe commented on SOLR-10011:
----------------------------------------------
I like the refactor.
bq. I think the refactoring in this patch is backwards compatible.
Kind of... Anyone using {{TrieFields.TrieTypes}}, {{TrieTypes.getType()}} or
{{TrieTypes.type}} will have their code failing. So I don't know if we consider
those kind of internal, or if we are OK with the change anyway since it's easy
to fix.
> Refactor PointField & TrieField to share common code
> ----------------------------------------------------
>
> Key: SOLR-10011
> URL: https://issues.apache.org/jira/browse/SOLR-10011
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Ishan Chattopadhyaya
> Attachments: SOLR-10011.patch, SOLR-10011.patch, SOLR-10011.patch,
> SOLR-10011.patch
>
>
> We should eliminate PointTypes and TrieTypes enum to have a common enum for
> both. That would enable us to share a lot of code between the two field types.
> In the process, fix the bug:
> PointFields with indexed=false, docValues=true seem to be using
> (Int|Double|Float|Long)Point.newRangeQuery() for performing exact matches and
> range queries. However, they should instead be using DocValues based range
> query.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
