[ 
https://issues.apache.org/jira/browse/SOLR-10018?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christine Poerschke updated SOLR-10018:
---------------------------------------
    Attachment: SOLR-10018-test.patch

Actually I didn't notice the absence of a test (I agree that not everything 
deserves one) but the {{The default is typically 51,200 but for ... it's 
10,000.}} jumped out and made me wonder if in future there could be another 
{{"is typically ... but for ... it's 51,200"}} repeat.

(Small test attached if you want it, but am definitely not insisting on one.)


> hl.maxAnalyzedChars should have consistent default across highlighters
> ----------------------------------------------------------------------
>
>                 Key: SOLR-10018
>                 URL: https://issues.apache.org/jira/browse/SOLR-10018
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: highlighter
>    Affects Versions: 6.4
>            Reporter: David Smiley
>            Assignee: David Smiley
>            Priority: Minor
>             Fix For: 6.5
>
>         Attachments: SOLR_10018__default_hl_maxAnalyazedChars.patch, 
> SOLR-10018-test.patch
>
>
> I see no reason why hl.maxAnalyzedChars should have different defaults per 
> highlighter implementation. The default is typically 51,200 but for the 
> UnifiedHighlighter and PostingsHighlighter it's 10,000. This could easily 
> lead to an unexpected lack of highlights that you expect to see when trying 
> the UH.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to